[release/v1.0] Fix bug when exporting a predicate name to the schema. #3701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is fixing #3699 for the 1.0 branch. The logic in this branch was slightly different. In this case, the brackets are only added if there's a colon in the predicate name. This logic is also buggy as it doesn't handle predicate names consisting of only numbers. The fix is to add the brackets for every predicate name for consistency and simplicity.
manishrjain
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
martinmr
commented
Jul 23, 2019
There was a problem hiding this comment.
Yeah, there's already a PR for that: #3700
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is fixing #3699 for the 1.0 branch. The logic in this branch
was slightly different. In this case, the brackets are only added if
there's a colon in the predicate name. This logic is also buggy as it
doesn't handle predicate names consisting of only numbers.
The fix is to add the brackets for every predicate name for consistency
and simplicity.
This change is